Fix: Simplify cache clearing/reset behaviour and do NOT exit with error#125
Merged
ModeSevenIndustrialSolutions merged 1 commit intolfreleng-actions:mainfrom Dec 31, 2025
Conversation
Copilot started reviewing on behalf of
ModeSevenIndustrialSolutions
December 24, 2025 08:30
View session
Contributor
Author
|
Fixes: 
|
There was a problem hiding this comment.
Pull request overview
This PR simplifies the cache clearing logic in the GitHub Action workflow to prevent matrix job failures. The previous implementation was too complex and caused sequencing issues where the first cache clearing build would succeed but subsequent matrix jobs would fail.
Key changes:
- Removed complex error handling that was causing workflows to exit on cache clearing failures
- Made cache clearing non-fatal to prevent workflow interruptions
- Simplified the cache deletion command and error messaging
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The previous cache clearing logic was too complex and caused sequencing issues in matrix jobs. The first cache clearing build would succeed, then all subsequent matrix jobs would fail. Failing to clear the Python build cache should not cause the workflow to stop/exit. Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
ModeSevenIndustrialSolutions
force-pushed
the
fix/cache-clear-matrix-race-condition
branch
from
8a74ced to
f79b8d9
Compare
zxiiro
approved these changes
Dec 24, 2025
ModeSevenIndustrialSolutions
merged commit 8f56739
into
lfreleng-actions:main
5 checks passed
ModeSevenIndustrialSolutions
deleted the
fix/cache-clear-matrix-race-condition
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous cache clearing logic was too complex and caused sequencing issues in matrix jobs. The first cache clearing build would succeed, then all subsequent matrix jobs would fail. Failing to clear the Python build cache should not cause the workflow to stop/exit.