Feat: Add make support for Python projects involving C code#126
Merged
ModeSevenIndustrialSolutions merged 1 commit intolfreleng-actions:mainfrom Dec 31, 2025
Conversation
Copilot started reviewing on behalf of
ModeSevenIndustrialSolutions
December 24, 2025 14:45
View session
There was a problem hiding this comment.
Pull request overview
This PR adds support for running make commands before the Python build process, enabling better support for Python projects that include C code or other components requiring compilation or preparation steps.
Key Changes:
- Adds two new input parameters:
make(boolean) to enable make execution, andmake_args(string) for passing arguments to the make command - Implements a two-step process: argument preparation that handles
path_prefixintegration, followed by conditional make execution via thelfreleng-actions/make-action - Updates testing workflow to validate the new functionality with multi-architecture builds
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| action.yaml | Adds make and make_args input definitions; implements make argument preparation step that integrates with path_prefix; adds conditional make execution step using external make-action; includes unrelated yamllint comment addition |
| README.md | Documents the two new input parameters in the inputs table |
| .github/workflows/testing.yaml | Enables make testing in the multi-architecture test job with parallel build arguments |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ModeSevenIndustrialSolutions
force-pushed
the
add-make-support
branch
from
b0dc4c7 to
db6a392
Compare
Copilot started reviewing on behalf of
ModeSevenIndustrialSolutions
December 24, 2025 15:04
View session
ModeSevenIndustrialSolutions
force-pushed
the
add-make-support
branch
from
db6a392 to
ca15681
Compare
ModeSevenIndustrialSolutions
force-pushed
the
add-make-support
branch
from
ca15681 to
fe90b11
Compare
Copilot started reviewing on behalf of
ModeSevenIndustrialSolutions
December 24, 2025 16:42
View session
ModeSevenIndustrialSolutions
force-pushed
the
add-make-support
branch
2 times, most recently
from
8a95eda to
e796878
Compare
- Allows for scripted steps prior to invoking the python build - Add make calls/args/inputs to MULTI_ARCH_TEST_PROJECTS build Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
ModeSevenIndustrialSolutions
force-pushed
the
add-make-support
branch
from
e796878 to
edee850
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zxiiro
approved these changes
Dec 24, 2025
ModeSevenIndustrialSolutions
merged commit 8b6a803
into
lfreleng-actions:main
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows for scripted steps prior to invoking the python build.