Fix: Incorrect input references directly in shell script contexts#78
Merged
tykeal merged 1 commit intolfreleng-actions:mainfrom Sep 10, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes security vulnerabilities by preventing direct shell injection of GitHub Actions inputs. Instead of directly interpolating input values into shell scripts, the changes use environment variables as an intermediary to safely pass input values to shell scripts.
- Replaces direct
${{ inputs.* }}references in shell scripts with environment variables - Adds proper variable assignment and quoting for shell safety
- Fixes boolean comparison logic for the
purge_artefact_pathinput
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ModeSevenIndustrialSolutions
force-pushed
the
update-action
branch
from
600029c to
71b6068
Compare
ModeSevenIndustrialSolutions
changed the title
Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
ModeSevenIndustrialSolutions
force-pushed
the
update-action
branch
from
71b6068 to
49bbff9
Compare
tykeal
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.