Skip to content

fix code duplication#25

Merged
lg2de merged 11 commits intomasterfrom
Duplication
Mar 7, 2020
Merged

fix code duplication#25
lg2de merged 11 commits intomasterfrom
Duplication

Conversation

@lg2de
Copy link
Copy Markdown
Owner

@lg2de lg2de commented Mar 7, 2020

Fixes #12

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #25 into master will increase coverage by 0.06%.
The diff coverage is 99.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   86.16%   86.23%   +0.06%     
==========================================
  Files          28       29       +1     
  Lines        2689     2564     -125     
  Branches      361      337      -24     
==========================================
- Hits         2317     2211     -106     
+ Misses        298      286      -12     
+ Partials       74       67       -7
Impacted Files Coverage Δ
src/SimpleAccounting/Reports/ReportBase.cs 100% <100%> (ø)
...impleAccounting/Reports/TotalsAndBalancesReport.cs 100% <100%> (+1.32%) ⬆️
src/SimpleAccounting/Reports/TotalJournalReport.cs 100% <100%> (+2.77%) ⬆️
...c/SimpleAccounting/Reports/AccountJournalReport.cs 98.03% <100%> (+1.63%) ⬆️
...rc/SimpleAccounting/Presentation/ShellViewModel.cs 83.06% <100%> (-0.03%) ⬇️
...rc/SimpleAccounting/Reports/AnnualBalanceReport.cs 92.8% <98.41%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1f6371...717f10b. Read the comment docs.

@lg2de lg2de merged commit 3edc097 into master Mar 7, 2020
@lg2de lg2de deleted the Duplication branch March 7, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

improve test coverage

2 participants