Skip to content

activate (nearly) all SonarQube rules and fix the issues#31

Merged
lg2de merged 8 commits intomasterfrom
SonarQube
Apr 3, 2020
Merged

activate (nearly) all SonarQube rules and fix the issues#31
lg2de merged 8 commits intomasterfrom
SonarQube

Conversation

@lg2de
Copy link
Copy Markdown
Owner

@lg2de lg2de commented Apr 3, 2020

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@c0aade4). Click here to learn what that means.
The diff coverage is 85.02%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #31   +/-   ##
=========================================
  Coverage          ?   87.81%           
=========================================
  Files             ?       32           
  Lines             ?     2560           
  Branches          ?      384           
=========================================
  Hits              ?     2248           
  Misses            ?      240           
  Partials          ?       72           
Impacted Files Coverage Δ
...ccounting/Presentation/CloseYearDesignViewModel.cs 100.00% <ø> (ø)
...impleAccounting/Presentation/DataGridExtensions.cs 0.00% <0.00%> (ø)
...SimpleAccounting/Presentation/MessageBoxWrapper.cs 0.00% <ø> (ø)
src/SimpleAccounting/Presentation/RelayCommand.cs 75.00% <ø> (ø)
src/SimpleAccounting/Presentation/ShellView.xaml 0.00% <ø> (ø)
src/SimpleAccounting/Reports/ReportBase.cs 100.00% <ø> (ø)
...Accounting/Presentation/ImportBookingsViewModel.cs 59.47% <28.07%> (ø)
.../SimpleAccounting/Presentation/AccountViewModel.cs 81.81% <66.66%> (ø)
...rc/SimpleAccounting/Presentation/ShellViewModel.cs 89.75% <88.03%> (ø)
...rc/SimpleAccounting/Reports/AnnualBalanceReport.cs 91.33% <91.30%> (ø)
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0aade4...d3baae1. Read the comment docs.

@lg2de lg2de merged commit 7976533 into master Apr 3, 2020
@lg2de lg2de deleted the SonarQube branch April 3, 2020 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant