Skip to content

Refactor ShellViewModel and improve coverage#36

Merged
lg2de merged 15 commits intomasterfrom
Refactoring
Apr 30, 2020
Merged

Refactor ShellViewModel and improve coverage#36
lg2de merged 15 commits intomasterfrom
Refactoring

Conversation

@lg2de
Copy link
Copy Markdown
Owner

@lg2de lg2de commented Apr 29, 2020

Description

The ShellViewModel has received a lot of code not really intended for a view model.
These changes are focussed on refactoring and better test coverage.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 29, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@a6eff59). Click here to learn what that means.
The diff coverage is 76.34%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #36   +/-   ##
=========================================
  Coverage          ?   85.29%           
=========================================
  Files             ?       35           
  Lines             ?     2740           
  Branches          ?      436           
=========================================
  Hits              ?     2337           
  Misses            ?      276           
  Partials          ?      127           
Impacted Files Coverage Δ
...rc/SimpleAccounting/Extensions/NumberExtensions.cs 100.00% <ø> (ø)
src/SimpleAccounting/Presentation/RelayCommand.cs 75.00% <ø> (ø)
...Accounting/Presentation/ImportBookingsViewModel.cs 59.68% <40.90%> (ø)
src/SimpleAccounting/Reports/XmlPrinter.cs 90.60% <46.15%> (ø)
...ting/Presentation/ImportBookingsDesignViewModel.cs 78.37% <50.00%> (ø)
...mpleAccounting/Infrastructure/ApplicationUpdate.cs 59.01% <59.01%> (ø)
...rc/SimpleAccounting/Presentation/ShellViewModel.cs 84.05% <72.22%> (ø)
...pleAccounting/Presentation/ImportEntryViewModel.cs 73.33% <83.33%> (ø)
...impleAccounting/Model/AccountingData.Extensions.cs 93.54% <94.62%> (ø)
...impleAccounting/Abstractions/SecureDriveStarter.cs 60.00% <100.00%> (ø)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6eff59...15ffaf6. Read the comment docs.

@lg2de lg2de merged commit 307a78d into master Apr 30, 2020
@lg2de lg2de deleted the Refactoring branch April 30, 2020 20:30
@lg2de lg2de added this to the 2.1 milestone Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant