Skip to content

introduce AsyncCommand for better handling of asynchronous operations#37

Merged
lg2de merged 10 commits intomasterfrom
AsyncCommand
May 2, 2020
Merged

introduce AsyncCommand for better handling of asynchronous operations#37
lg2de merged 10 commits intomasterfrom
AsyncCommand

Conversation

@lg2de
Copy link
Copy Markdown
Owner

@lg2de lg2de commented May 2, 2020

Description

Some operations were defined asynchronously but not fully used like that.
Added custom AsyncCommand (inspired by https://docs.microsoft.com/de-de/archive/msdn-magazine/2014/april/async-programming-patterns-for-asynchronous-mvvm-applications-commands) triggering IsBusy for consistent progress information.

@codecov
Copy link
Copy Markdown

codecov bot commented May 2, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@307a78d). Click here to learn what that means.
The diff coverage is 69.14%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #37   +/-   ##
=========================================
  Coverage          ?   84.75%           
=========================================
  Files             ?       37           
  Lines             ?     2808           
  Branches          ?      456           
=========================================
  Hits              ?     2380           
  Misses            ?      301           
  Partials          ?      127           
Impacted Files Coverage Δ
...mpleAccounting/Infrastructure/ApplicationUpdate.cs 52.94% <0.00%> (ø)
...rc/SimpleAccounting/Infrastructure/RelayCommand.cs 75.00% <ø> (ø)
...pleAccounting/Infrastructure/SecureDriveStarter.cs 60.00% <ø> (ø)
.../SimpleAccounting/Presentation/AccountViewModel.cs 81.81% <ø> (ø)
...mpleAccounting/Presentation/AddBookingViewModel.cs 92.39% <ø> (ø)
...impleAccounting/Presentation/CloseYearViewModel.cs 93.75% <ø> (ø)
...Accounting/Presentation/ImportBookingsViewModel.cs 59.68% <ø> (ø)
...pleAccounting/Presentation/ImportEntryViewModel.cs 73.33% <ø> (ø)
...SimpleAccounting/Presentation/MessageBoxWrapper.cs 0.00% <0.00%> (ø)
...rc/SimpleAccounting/Presentation/ShellViewModel.cs 82.51% <62.50%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 307a78d...2f705e7. Read the comment docs.

@lg2de lg2de merged commit bd2243d into master May 2, 2020
@lg2de lg2de deleted the AsyncCommand branch May 2, 2020 20:08
@lg2de lg2de added this to the 2.1 milestone May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant