fix: bring the test suite back to the pass state on newer GLib#361
Open
luau-project wants to merge 5 commits intolgi-devs:masterfrom
Open
fix: bring the test suite back to the pass state on newer GLib#361luau-project wants to merge 5 commits intolgi-devs:masterfrom
luau-project wants to merge 5 commits intolgi-devs:masterfrom
Conversation
Collaborator
|
Adding some reviewers that recently "did stuff" to LGI |
|
For me the changes in this PR seem to work. Tested on Fedora 44 (beta) with lua 5.4.8. |
Contributor
Aire-One
approved these changes
Apr 23, 2026
Contributor
Author
|
removed in-code comments according to @Aire-One review |
Aire-One
reviewed
Apr 23, 2026
Aire-One
approved these changes
Apr 23, 2026
Contributor
Aire-One
left a comment
Aire-One
left a comment
There was a problem hiding this comment.
Sorry for the back and forth 😬
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to bring back LGI's test suite (
make check) to the pass state on newer GLib.I would like to invite @reinerh , @ildar , @ji-cerny to test the proposed changes.
OS under test
Note
I used only Lua 5.5.0 on my tests.