Use torchaudio to read sph files first#1067
Open
desh2608 wants to merge 20 commits intolhotse-speech:masterfrom
Open
Use torchaudio to read sph files first#1067desh2608 wants to merge 20 commits intolhotse-speech:masterfrom
desh2608 wants to merge 20 commits intolhotse-speech:masterfrom
Conversation
Collaborator
|
Did you check that it works with |
Collaborator
Author
Is it in any of the test cases? I only tried it on ICSI dataset where it works fine, but I'm not sure how those are encoded. I can add a test cases for shorten. |
Collaborator
|
No, I don't think it's in the tests. You'd have to try something old like maybe Callhome, not sure but maybe also SWBD. I don't remember which corpora this happened with unfortunately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New torchaudio with ffmpeg backend can read SPH files. It doesn't seem to be any faster than sph2pipe, but at least it does not require installing new tools.