Skip to content

Comments

Added handlings for negative end time (#1203)#1263

Open
ArthLeu wants to merge 1 commit intolhotse-speech:masterfrom
ArthLeu:master
Open

Added handlings for negative end time (#1203)#1263
ArthLeu wants to merge 1 commit intolhotse-speech:masterfrom
ArthLeu:master

Conversation

@ArthLeu
Copy link

@ArthLeu ArthLeu commented Jan 17, 2024

Formatted with Black this time.

@desh2608
Copy link
Collaborator

desh2608 commented Jan 17, 2024

Alignment times are supposed to be w.r.t. the recording, so I don't see how the start/end could be negative?

See:

class AlignmentItem(NamedTuple):

@pzelasko
Copy link
Collaborator

@desh2608 Are we not adjusting alignment times together with supervision times when creating a cut?

@ArthLeu could you add a unit test that would have failed before but will pass correctly now to cover your changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants