add a param tolerance of cut.py simple#1385
Open
yunxinmengze wants to merge 2 commits intolhotse-speech:masterfrom
Open
add a param tolerance of cut.py simple#1385yunxinmengze wants to merge 2 commits intolhotse-speech:masterfrom
yunxinmengze wants to merge 2 commits intolhotse-speech:masterfrom
Conversation
Contributor
|
This PR can be used to fix importing data files from kaldi. you can see from the above screenshot, we need a larger tolerance value, e.g., 0.1. Could you also fix We need to change lhotse cut simple \
-r ./data/train_manifests/recordings.jsonl.gz \
-f ./data/train_manifests/features.jsonl.gz \
-s ./data/train_manifests/supervisions.jsonl.gz \
./yesno_train.jsonl.gzto lhotse cut simple \
-r ./data/train_manifests/recordings.jsonl.gz \
-f ./data/train_manifests/features.jsonl.gz \
-s ./data/train_manifests/supervisions.jsonl.gz \
--tolerance 0.1 \
./yesno_train.jsonl.gz
|
Collaborator
|
Thanks! I'd be fine with setting the default tolerance to 0.1 if you want to make that change as well. |
Collaborator
|
@yunxinmengze can you reformat the PR with black and commit again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.