Skip to content

Comments

add a param tolerance of cut.py simple#1385

Open
yunxinmengze wants to merge 2 commits intolhotse-speech:masterfrom
yunxinmengze:master
Open

add a param tolerance of cut.py simple#1385
yunxinmengze wants to merge 2 commits intolhotse-speech:masterfrom
yunxinmengze:master

Conversation

@yunxinmengze
Copy link

No description provided.

@csukuangfj
Copy link
Contributor

csukuangfj commented Aug 9, 2024

This PR can be used to fix importing data files from kaldi.

For the yesno example,
Screenshot 2024-08-09 at 19 52 25

you can see from the above screenshot, we need a larger tolerance value, e.g., 0.1.


@yunxinmengze

Could you also fix
https://github.com/lhotse-speech/lhotse/blob/master/docs/kaldi.rst

We need to change

lhotse cut simple \
  -r ./data/train_manifests/recordings.jsonl.gz \
  -f ./data/train_manifests/features.jsonl.gz \
  -s ./data/train_manifests/supervisions.jsonl.gz \
  ./yesno_train.jsonl.gz

to

lhotse cut simple \
  -r ./data/train_manifests/recordings.jsonl.gz \
  -f ./data/train_manifests/features.jsonl.gz \
  -s ./data/train_manifests/supervisions.jsonl.gz \
  --tolerance 0.1 \
  ./yesno_train.jsonl.gz

@pzelasko
Copy link
Collaborator

Thanks! I'd be fine with setting the default tolerance to 0.1 if you want to make that change as well.

@pzelasko
Copy link
Collaborator

@yunxinmengze can you reformat the PR with black and commit again?

@pzelasko pzelasko added this to the v1.28.0 milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants