allow more than one candidate backends#1441
Closed
lifeiteng wants to merge 0 commit intolhotse-speech:masterfrom
Closed
allow more than one candidate backends#1441lifeiteng wants to merge 0 commit intolhotse-speech:masterfrom
lifeiteng wants to merge 0 commit intolhotse-speech:masterfrom
Conversation
Collaborator
|
Can you elaborate why is this change needed? |
Contributor
Author
|
I want to try use different backends for opus: |
Collaborator
|
Could you instead remove the condition in lines 514-515 in lhotse/audio/backend.py? lhotse/lhotse/audio/backend.py Lines 514 to 515 in 509f4a9 |
Contributor
Author
done |
Collaborator
|
Thanks, I meant to also revert the change removing the check for unique backends - I think it is useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.