BUGFIX: TabixIterator does not have attribute .next(), added note in …#59
Merged
lhqing merged 4 commits intolhqing:masterfrom Feb 21, 2025
Merged
BUGFIX: TabixIterator does not have attribute .next(), added note in …#59lhqing merged 4 commits intolhqing:masterfrom
lhqing merged 4 commits intolhqing:masterfrom
Conversation
Contributor
Author
|
I also found a small bug in merge-allc in which this line
was causing an error. Seems like a simple fix to replace '(' with '['. |
Owner
|
Thank you for the bug fix! I fixed a conflicts and merge this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In latest version of pysam (v0.22.1),
TabixIterator.next()does not exist and soself.f_region.next()throws an error. Replaced withself.f_region.__next__()and this seems to work. I also added a small note about the--output_pathparam in themerge-allccommand. When I did not use the tsv.gz extension, tabix was unable to recognize the file. I'm not sure what the full spectrum of allowable extensions is, but it would be good to have this documented.