Conversation
There was a problem hiding this comment.
Pull request overview
This pull request removes the proxy failure tracking and automatic backoff mechanism that was previously disabling weather service proxies after repeated failures. The change is motivated by Weathercloud being unreliable and the fact that weather stations send updates infrequently (at most once per minute), making permanent disabling of forwarding problematic when there's no way to re-enable it without reconfiguration.
Changes:
- Removed failure tracking data structures (
proxy_failure_countsanddisabled_proxy_sinks) - Simplified error handling to log failures without counting or disabling proxies
- Improved session.closed handling to allow retries on subsequent requests rather than permanent disabling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Weathercloud seems unreliable. And without an option to re-enable the sending this is just annoying.
Also its at most one request per minute. So whatever