-
Notifications
You must be signed in to change notification settings - Fork 190
💄 Show Indexes instead of Unique #964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 347c7b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@ya2s is attempting to deploy a commit to the ROUTE06 Core Team on Vercel. A member of the Team first needs to authorize it. |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||
MH4GF
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there's no problem with the implementation.
It's just that the lint is falling, so please check it!
.../src/features/erd/components/ERDContent/components/TableNode/TableDetail/Indices/Indices.tsx
Outdated
Show resolved
Hide resolved
.../src/features/erd/components/ERDContent/components/TableNode/TableDetail/Indices/Indices.tsx
Outdated
Show resolved
Hide resolved
d82dbea to
13a1d67
Compare
MH4GF
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻 Thanks!!
|
@ya2s Please resolve conflict? |
Issue
The Unique section is no longer needed, so replace it with Indexes
Why is this change needed?
What would you like reviewers to focus on?
Testing Verification
What was done
🤖 Generated by PR Agent at 1a4795a
Uniquesection withIndexesin the UI.IndexesItemcomponent for displaying index details.Uniquecomponent and associated styles.Indexesfeature.Detailed Changes
6 files
Export `IndexesItem` component for reuseAdd `FileText` icon exportAdd styles for `IndexesItem` componentImplement `IndexesItem` component for displaying index detailsUpdate `Indices` component to use `IndexesItem`Add `FileText` icon component5 files
Remove export for `Unique` componentRemove obsolete styles for `Indices` componentRemove obsolete styles for `Unique` componentRemove `Unique` component reference from `TableDetail`Remove `Unique` component implementation1 files
Add changeset for replacing `Unique` with `Indexes`Additional Notes