-
Notifications
You must be signed in to change notification settings - Fork 190
🔧 Match next-config settings with docs so that sourcemap can be sent.
#977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
|
Updates to Preview Branch (update-app-next-config) ↗︎
Tasks are run on every commit but only new migration files are pushed.
View logs for this Workflow Run ↗︎. |
3d05eb1 to
6df9eb7
Compare
6df9eb7 to
fc06bcd
Compare
next-config settings with docs so that sourcemap can be sent.
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
MH4GF
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
Issue
Recently in
liam-app, sourcemap was not being sent to sentry.I thought I needed
sourcemap.assetsas per the warning, but I was able to send sourcemap without setting assets in docs, so I changed the settings as in docs. (I removed the assets setting)docs sentry setting is here:
liam/frontend/apps/docs/next.config.mjs
Lines 18 to 56 in 82a5365
I confirmed that the sourcemap was successfully sent.✅
vercel: https://vercel.com/route-06-core/liam-app/Hhoy2UgTWSZNk8ZXBzTwLAwwUqn7
sentry: https://route06cojp.sentry.io/settings/projects/liam-erd-web/source-maps/
Why is this change needed?
What would you like reviewers to focus on?
Testing Verification
What was done
🤖 Generated by PR Agent at fc06bcd
sourcemapssettings fromnext.config.ts.hideSourceMapsfor source map management.Detailed Changes
next.config.ts
Removed incorrect sourcemap settings in `next.config.ts`frontend/apps/app/next.config.ts
sourcemapsconfiguration block.hideSourceMapsfor managing source map visibility.documentation.
Additional Notes