-
Notifications
You must be signed in to change notification settings - Fork 3
docs: enhance README structure and add workflow improvements #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- reframe the README around the SDD prompt lifecycle and artifacts - document MCP prompt support behaviors across popular IDE and CLI setups
Move markdownlint rule configuration from inline pre-commit hook arguments to a dedicated .markdownlint.yaml file for better maintainability and adherence to standard practices. This also allows other tooling to pick up on the markdown config. Changes: - Create .markdownlint.yaml with disabled rules (MD013, MD024, MD033, MD034, MD041) - Remove --disable arguments from markdownlint-fix hook in .pre-commit-config.yaml - Maintain existing exclusions for CHANGELOG.md and LICENSE This improves configuration management without changing linting behavior. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add centered header layout with tagline and multiple badges including CI status, GitHub stars, and documentation links. Improve visual presentation and project discoverability.
Add comprehensive overview sections to improve first-time user experience and clarify the relationship between prompts and optional MCP tooling. Changes: - Add "Highlights" section summarizing key value propositions - Insert "Prompt Workflow" section with numbered workflow steps - Add "How does it work?" explanation of the prompt-driven approach - Include "Workflow Essentials" with practical getting-started steps - Clarify that MCP is an optional integration layer - Improve link formatting consistency throughout document These additions provide better information architecture and help users understand the workflow before diving into detailed implementation stages. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
WalkthroughConfiguration and documentation updates restructure the project around a Markdown-prompt-centric workflow. Changes include a new linting configuration file, simplification of pre-commit hooks, substantial README reorganization emphasizing prompt workflows and artifacts, new MCP tool support documentation, and a basic HTTP health endpoint in the server code. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
mcp_server/__init__.py (1)
26-28: Health endpoint works but is minimal.The implementation is correct and follows standard health check patterns. For a prompt-serving MCP server, a simple "OK" response may be sufficient.
Consider whether future enhancements should verify:
- Prompt directory accessibility
- Configuration validity
- Any external dependencies
README.md (1)
24-24: Consider hyphenating compound adjective.Static analysis suggests "Spec-Driven Development" (with hyphen) when used as a compound adjective modifying "Development." This applies to the heading and similar uses throughout the document.
While the current usage is understood, consider this change for grammatical precision:
-## Why Spec Driven Development? +## Why Spec-Driven Development?Apply similar changes to other occurrences where "Spec Driven" modifies a noun (e.g., line 26). Note that "Spec Driven Development" as a proper name (e.g., in the title) can remain unhyphenated.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.markdownlint.yaml(1 hunks).pre-commit-config.yaml(0 hunks)README.md(3 hunks)docs/mcp-prompt-support.md(1 hunks)mcp_server/__init__.py(2 hunks)
💤 Files with no reviewable changes (1)
- .pre-commit-config.yaml
🧰 Additional context used
🪛 LanguageTool
README.md
[grammar] ~24-~24: Use a hyphen to join words.
Context: ...n inside modern AI clients. ## Why Spec Driven Development? Spec Driven Develop...
(QB_NEW_EN_HYPHEN)
🔇 Additional comments (13)
.markdownlint.yaml (1)
1-20: LGTM! Configuration aligns well with documentation needs.The disabled rules are appropriate for this project:
- MD033 (inline HTML) and MD041 (first line heading) accommodate the HTML header in README.md
- MD013 (line length) provides flexibility for long URLs and code blocks
- MD024 (duplicate headings) and MD034 (bare URLs) offer practical flexibility for documentation
mcp_server/__init__.py (2)
8-9: LGTM! Correct imports for the health endpoint.The starlette imports are appropriate for implementing a custom HTTP route within the FastMCP framework.
33-37: LGTM! Test tool registration is appropriate.The basic example tool serves its stated purpose of verifying MCP tool registration. The static return value is suitable for a verification tool.
docs/mcp-prompt-support.md (3)
1-23: LGTM! Well-structured support matrix with clear contribution path.The table provides valuable guidance for users selecting tools, and the TBD entries appropriately signal areas awaiting community validation. The categorization (Ideal/Not good/Non-existent/TBD) gives users quick insight into tool readiness.
31-36: Field notes align with codebase changes.The Windsurf note about requiring a placeholder tool aligns with the
basic_example_toolregistration added inmcp_server/__init__.py, demonstrating consistency between documentation and implementation.
38-46: LGTM! Clear contribution workflow.The five-step contribution process is straightforward and encourages community participation in validating tool support.
README.md (7)
18-36: LGTM! Clear highlights and principles establish the workflow's value.The highlights section effectively communicates the prompt-first approach, and the guiding principles provide actionable constraints that align with the documented workflow stages.
38-71: LGTM! Workflow sections provide clear, actionable guidance.The progression from prompt workflow overview through detailed stage descriptions gives users a complete mental model. The explicit artifact locations (
tasks/, filename patterns) make outcomes tangible.
74-109: LGTM! Mermaid diagram effectively visualizes the three-stage workflow.The sequence diagram clearly shows participant interactions and the bidirectional feedback loops (analyze → clarify → refine). The participant naming aligns with the documented prompt filenames.
111-139: LGTM! Core artifacts and hands-on usage deliver practical next steps.The artifact definitions establish clear conventions (status markers, file patterns), and the hands-on usage section provides a concrete entry point for users who want to start without MCP tooling. The cross-reference to
docs/mcp-prompt-support.md(added in this PR) maintains consistency.
140-171: LGTM! Installation and run instructions are clear and complete.The instructions cover multiple transport modes (STDIO, inspector, HTTP) and reference the appropriate documentation files for advanced scenarios.
173-183: LGTM! References and license are properly documented.The reference table provides context for foundational concepts (AI Dev Tasks, MCP, FastMCP), and the license reference is correctly formatted.
1-16: LGTM! Professional header with proper badge configuration.The HTML-based header provides visual polish, and the disabled MD033/MD041 linting rules appropriately accommodate this structure. Badge URLs correctly reference the repository. The header image at
./misc/header.pngexists and is accessible.
* docs: refocus workflow guidance and tooling notes - reframe the README around the SDD prompt lifecycle and artifacts - document MCP prompt support behaviors across popular IDE and CLI setups * feat: add health check for mcp * build(linter): centralize markdownlint configuration Move markdownlint rule configuration from inline pre-commit hook arguments to a dedicated .markdownlint.yaml file for better maintainability and adherence to standard practices. This also allows other tooling to pick up on the markdown config. Changes: - Create .markdownlint.yaml with disabled rules (MD013, MD024, MD033, MD034, MD041) - Remove --disable arguments from markdownlint-fix hook in .pre-commit-config.yaml - Maintain existing exclusions for CHANGELOG.md and LICENSE This improves configuration management without changing linting behavior. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * docs: enhance README header with badges and improved formatting Add centered header layout with tagline and multiple badges including CI status, GitHub stars, and documentation links. Improve visual presentation and project discoverability. * docs: enhance README structure with highlights and workflow guidance Add comprehensive overview sections to improve first-time user experience and clarify the relationship between prompts and optional MCP tooling. Changes: - Add "Highlights" section summarizing key value propositions - Insert "Prompt Workflow" section with numbered workflow steps - Add "How does it work?" explanation of the prompt-driven approach - Include "Workflow Essentials" with practical getting-started steps - Clarify that MCP is an optional integration layer - Improve link formatting consistency throughout document These additions provide better information architecture and help users understand the workflow before diving into detailed implementation stages. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * docs: minor tweak --------- Co-authored-by: Claude <noreply@anthropic.com>
Why?
Improve README discoverability, readability, and user onboarding by enhancing the documentation structure and visual presentation. This PR consolidates recent documentation improvements and workflow clarifications to better communicate the value proposition and usage patterns of the Spec Driven Development workflow.
What Changed?
Documentation Enhancements
Build & Configuration
.markdownlint.yamlfile for better maintainabilityFeature Additions
/healthendpoint for MCP server monitoring and deployment readiness checksAdditional Notes
This PR brings together several improvements that enhance both the user experience and operational capabilities:
Checklist: