-
Notifications
You must be signed in to change notification settings - Fork 3
docs(readme): add detailed explanations to quickstart section #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe README.md file is comprehensively restructured to shift from a brief TLDR to a detailed workflow guide. It now includes expanded installation options (Slash Commands and Manual Copy-Paste), a new 4-Step Workflow section with explicit stages, detailed prompts and expected artifacts, and security-focused content. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
README.md (2)
274-274: Create the missingdocs/mcp-prompt-support.mdfile or update the broken link reference on line 274.Line 274 in README.md references
./docs/mcp-prompt-support.md, but this file does not exist in the repository. This will result in a broken link for users trying to access MCP prompt support details. Either:
- Create the missing
docs/mcp-prompt-support.mddocumentation file, or- Update the link on line 274 to point to an existing resource
The GitHub Pages documentation links on lines 109–116 are properly formatted and accessible.
278-280: Path inconsistency confirmed: line 278 contradicts documented spec artifact locationLine 278 directs users to output specs to
tasks/, but lines 56, 129, 234, and 244 consistently document the actual spec artifact location asdocs/specs/[NN]-spec-[feature-name]/. This inconsistency will misdirect users during their first workflow run.Apply this diff to align line 278 with the documented spec artifact directory:
-1. Open `prompts/generate-spec.md` inside your AI assistant and follow the instructions to produce a new spec in `tasks/`. +1. Open `prompts/generate-spec.md` inside your AI assistant and follow the instructions to produce a new spec in `docs/specs/[NN]-spec-[feature-name]/`.
🧹 Nitpick comments (1)
README.md (1)
122-159: Recommended: Consider consolidating overlapping workflow guidanceThe Quickstart section (lines 54–73) and the detailed "Workflow Overview" section (lines 122–159) cover similar ground. While the Overview provides valuable depth for power users, newer users might benefit from a cross-reference ("For more details, see Workflow Overview below") to reduce cognitive load and signpost the progressive disclosure pattern you've intentionally created.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md(2 hunks)
🔇 Additional comments (3)
README.md (3)
19-48: Well-structured expansion of installation guidanceThe addition of the "What is this?" section and bifurcated installation options (Slash Commands vs. Manual Copy-Paste) significantly improves onboarding clarity. The comparison of
uvxtonpxis a helpful mental model for Python-unfamiliar users, and the step-by-step breakdown of what the command does (lines 37–44) removes guesswork.
50-73: Clear workflow structure with consistent artifact documentationThe 4-Step Workflow section is well-organized, each stage now includes explicit "What it does," "Output," and "Why" subsections. File paths use the
[NN]and[TT]placeholder convention consistently with downstream sections. The progression from Spec → Task List → Manage Tasks → Validate Implementation is logical and easy to follow.
282-293: Strong addition: Security best practices for proof artifactsThe new Security Best Practices section is well-timed and practical. Recommending gitleaks and similar tooling as preventive guards is sound, and the emphasis on developer responsibility before commits sets the right tone.
README.md
Outdated
| **Want to install these prompts as slash commands?** Use the [slash-command-manager](https://github.com/liatrio-labs/slash-command-manager) utility to install them in all of your local AI tools: | ||
| ### What is this? | ||
|
|
||
| This repository provides **structured prompts** (Markdown files) that guide AI assistants through a complete software development workflow: from initial feature idea → detailed specification → task breakdown → implementation → validation. Think of them as reusable playbooks that keep AI agents focused and consistent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like the "feature idea" to be external in a feature/story etc. and this to be the next level down. Maybe that's in the details....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
Why?
The TL/DR quickstart section lacked sufficient detail for new users to understand what the
uvxcommand does and what the workflow files are at a high level. This made it difficult for readers to quickly grasp the purpose and mechanics of the spec-driven workflow.What Changed?
uvxcommand does (explainsuvxis likenpxfor Python, details each command component)Additional Notes
This improves onboarding experience for new users who were confused by the original quickstart format.
tasks/0002-spec-open-source-ready.md) - N/A, documentation improvementuv run pytestuv run pre-commit run --all-filesSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.