Support multiple values in host, hostaddr, and port #1246
+767
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to libpq, you can now use multiple values in host, hostaddr, and
port to try more than one server to connect to:
host=pg.localhost,backup.localhost
Additional hosts are added to Config.Multi. I originally looked at
changing Config.{Host,Hostaddr,Port} to a slice, but I found this
awkward to use both in the code here and as a client. I also looked at
using a []Config, which I found similarly awkward.
Putting additional hosts in a separate struct field keeps things
straight-forward for the common use case (just one host), and with the
hosts() method it's fairly straight-forward to use. hosts() is not
exported because it assumes Config is correctly validated, and I'm not
sure if it's really useful for anyone else. But if there's a use-case
for it then it can be exported.
Fixes #683
Closes #714
arp242
force-pushed
the
multi
branch
2 times, most recently
from
7bfb5be to
3538233
Compare
Applies both connecting to a single host ("host=localhost") and multiple
hosts ("host=one,two").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to libpq, you can now use multiple values in host, hostaddr, and port to try more than one server to connect to:
Additional hosts are added to Config.Multi. I originally looked at changing Config.{Host,Hostaddr,Port} to a slice, but I found this awkward to use both in the code here and as a client. I also looked at using a []Config, which I found similarly awkward.
Putting additional hosts in a separate struct field keeps things straight-forward for the common use case (just one host), and with the hosts() method it's fairly straight-forward to use. hosts() is not exported because it assumes Config is correctly validated, and I'm not sure if it's really useful for anyone else. But if there's a use-case for it then it can be exported.
Fixes #683
Closes #714