PageNum and PageTranstion renamed#60
Merged
Merged
Conversation
Signed-off-by: Dmitry Solomennikov <dmitrys99@mail.ru>
Signed-off-by: Dmitry Solomennikov <dmitrys99@mail.ru>
Signed-off-by: Dmitry Solomennikov <dmitrys99@mail.ru>
Signed-off-by: Dmitry Solomennikov <dmitrys99@mail.ru>
Signed-off-by: Dmitry Solomennikov <dmitrys99@mail.ru>
Signed-off-by: Dmitry Solomennikov <dmitrys99@mail.ru>
55728
reviewed
May 11, 2026
Member
55728
left a comment
55728
left a comment
There was a problem hiding this comment.
Thank you for this massive cleanup — removing bindings/, dropping LIBBRST_ISO_216_ONLY, renaming the enums in C headers, and adding the docs! 😊
I rebuilt brst-binding-ruby against this branch and re-ran the MISSING_SYMBOLS check. One small thing: gen/data/doc_page.lsp:237 still references "PageNumStyle", but the C header now uses PageNum. Updating that one spot should resolve the BRST_Doc_Page_AddLabel type error.
Signed-off-by: Dmitry Solomennikov <dmitrys99@mail.ru>
Contributor
Author
|
Let's merge it and postpone image naming in pair with #31. |
Signed-off-by: Dmitry Solomennikov <dmitrys99@mail.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The real issue in #59 is that enums
PageNumandPageTransitionare already in*.lsp, but in*.hare not renamed.Codebase is working well since enum values are the same, but data files and headers are out of sync.
This PR must be applied after #58