Initialize values in our test instantiations#28
Merged
roystgnr merged 1 commit intolibMesh:masterfrom Jul 5, 2022
Merged
Conversation
We do want to allow our numeric classes to have uninitialized instantiations, because every operation here counts and because we want them to behave like built-in numeric types in that respect. But in a test where we're going to *output* their values, we really need to instantiate them. This fixes a bug for me where every several dozen runs was kicking up SIGFPE.
Member
Author
|
At some point our |
roystgnr
added a commit
to roystgnr/libmesh
that referenced
this pull request
Jul 5, 2022
This picks up libMesh/MetaPhysicL#28 and so should hopefully end our intermittent CI failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do want to allow our numeric classes to have uninitialized
instantiations, because every operation here counts and because we want
them to behave like built-in numeric types in that respect.
But in a test where we're going to output their values, we really need
to instantiate them.
This fixes a bug for me where every several dozen runs was kicking up
SIGFPE.