Build breaks with clang-19: no member named 'get' in 'ParameterProxy<T>'

[yurivict]

In file included from src/solvers/twostep_time_solver.C:26:
In file included from ./include/libmesh/parameter_vector.h:26:
./include/libmesh/parameter_accessor.h:115:95: error: no member named 'get' in 'ParameterProxy<T>'
  115 |   ParameterProxy & operator = (const ParameterProxy<T> & new_value) { _accessor.set(new_value.get()); }
      |                                                                                     ~~~~~~~~~ ^

This patch removing unused methods should help:

--- include/systems/parameter_accessor.h.orig   2024-11-04 03:11:10 UTC
+++ include/systems/parameter_accessor.h
@@ -112,13 +112,14 @@ class ParameterProxy (public)
   /**
    * Setter: change the value of the parameter we access.
    */
+#if 0
   ParameterProxy & operator = (const ParameterProxy<T> & new_value) { _accessor.set(new_value.get()); }
 
   /**
    * Setter: change the value of the parameter we access.
    */
   ParameterProxy & operator = (const ConstParameterProxy<T> & new_value) { _accessor.set(new_value.get()); return *this; }
-
+#endif
   /**
    * Setter: change the value of the parameter we access.
    */

Version: 1.7.5
FreeBSD 14.1

[roystgnr]

IIRC we have applications which use the ParameterProxy = ConstParameterProxy case, but apparently they only ever use the ConstParameterProxy case.

I can reproduce this with clang-19 on Ubuntu; I'll test a fix with that.