Elem::_children should be a unique_ptr to an array of Elem*#3334
Merged
jwpeterson merged 1 commit intolibMesh:develfrom Jul 6, 2022
Merged
Elem::_children should be a unique_ptr to an array of Elem*#3334jwpeterson merged 1 commit intolibMesh:develfrom
jwpeterson merged 1 commit intolibMesh:develfrom
Conversation
Member
jwpeterson
commented
Jul 6, 2022
jwpeterson
commented
- The Elem class is no longer manually mangaging any memory
- Default the Elem destructor
roystgnr
reviewed
Jul 6, 2022
| libmesh_assert_equal_to (this->refinement_flag(), Elem::COARSEN_INACTIVE); | ||
| libmesh_assert (!this->active()); | ||
|
|
||
| // We no longer delete children until MeshRefinement::contract() |
Member
There was a problem hiding this comment.
Can we keep this comment in? Or we could lengthen it to talk about subactive elements. But either way it's expressing something that's important, not intuitive, and not explicit in the code.
Member
Author
There was a problem hiding this comment.
Yes, good point. It got swept up in my removal of the line below.
roystgnr
approved these changes
Jul 6, 2022
* The Elem class is no longer manually mangaging any memory * Default the Elem destructor
jwpeterson
force-pushed
the
elem_children_unique_ptr
branch
from
13d9755 to
dac2e95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.