Still more test coverage#3421
Merged
roystgnr merged 9 commits intolibMesh:develfrom Nov 3, 2022
Merged
Conversation
We had a ton of testing for this in GRINS, but we no longer do CI with GRINS, and even if we add it back in we'd still like to have full coverage *internal* to libMesh.
This fits the pattern we use in other enumerated classes.
This was supposed to be a simple test, then after I discovered Partitioner::type() didn't exist stubbornness prevented me from deleting the test.
I need to do more testing with this, figure out whether distributed-vs-replicated is really what's triggering failures for me, but for now let's at least throw a warning there.
This made it easier to hunt for bounds to test
I'm going to futz with this example a bit for more test coverage, and I'd like to know if I break it too badly.
We didn't have any test coverage on the code paths this hits.
|
Job Coverage on 9229e5e wanted to post the following: Coverage
Warnings
This comment will be updated on new commits. |
||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.