Xdr string_view comments#3439
Merged
roystgnr merged 3 commits intolibMesh:develfrom Nov 21, 2022
Merged
Conversation
sprintf is deprecated on new Macs
This should give us a bit more efficiency+flexibility.
roystgnr
force-pushed
the
xdr_string_view
branch
from
79ab672 to
47d25a7
Compare
Member
|
Is this ready? :-) |
Member
Author
|
It's ready, if you want to review. The important commit is already merged via #3438, though. That's enough to fix the deprecation issues you saw, right? I usually don't merge my own feature update PRs unless they've gotten a review or I've let them sit a week or so to give opportunity for review. Bug fixes I'll get in ASAP, but for anything that's not urgent I like to have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is built on top of (and I noticed the opportunity while making) #3438, but it's not an urgent fix like that one is, just an API upgrade I missed while hunting for good string_view opportunities in #3204.