Refinement capability for Prism21, fixes for Tri7, test coverage#3445
Merged
roystgnr merged 9 commits intolibMesh:develfrom Nov 23, 2022
Merged
Refinement capability for Prism21, fixes for Tri7, test coverage#3445roystgnr merged 9 commits intolibMesh:develfrom
roystgnr merged 9 commits intolibMesh:develfrom
Conversation
|
Job Coverage on 2500494 wanted to post the following: Coverage
Warnings
This comment will be updated on new commits. |
||||||||||||||||||||||||||
At some point between Tet14 and Pyramid21 we exceeded my capacity to correct these things one entry at a time.
I need to come up with some hack to make those internal bracketing nodes work.
Yes, I tripped this one. Turns out that you create an empty
vector<pair> with {}, not with {{}}.
This lets us run with prism elements and Tri7-based elements too
roystgnr
force-pushed
the
embedding_updates
branch
from
420ba50 to
2500494
Compare
Member
Author
|
Cleaned up history; this isn't too invasive on non-Tri7-based elements, so if CI is still happy I'll merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.