Skip to content

Use FDM for higher-order SIDE_HIERARCHIC Hexes for now #3448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roystgnr merged 2 commits into from
Dec 5, 2022
Merged

Use FDM for higher-order SIDE_HIERARCHIC Hexes for now #3448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5f51a3
FDM can fix high-order SIDE_HIERARCIC for now
roystgnr Dec 1, 2022
9d66fb9
Test higher-order SIDE_HIERARCHIC on Hexes
roystgnr Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/fe/fe_hierarchic_shape_3D.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1230,6 +1230,10 @@ Real FE<3,SIDE_HIERARCHIC>::shape_deriv(const Elem * elem,
{
case HEX27:
{
// I need to debug the p>2 case here...
if (totalorder > 2)
return fe_fdm_deriv(elem, order, i, j, p, add_p_level, FE<3,SIDE_HIERARCHIC>::shape);

const unsigned int dofs_per_side = (totalorder+1u)*(totalorder+1u);
libmesh_assert_less(i, 6*dofs_per_side);

Expand Down Expand Up @@ -1486,6 +1490,11 @@ Real FE<3,SIDE_HIERARCHIC>::shape_second_deriv(const Elem * elem,
{
case HEX27:
{
// I need to debug the p>2 case here...
if (totalorder > 2)
return fe_fdm_second_deriv(elem, order, i, j, p, add_p_level,
FE<3,SIDE_HIERARCHIC>::shape_deriv);

const unsigned int dofs_per_side = (totalorder+1u)*(totalorder+1u);
libmesh_assert_less(i, 6*dofs_per_side);

Expand Down
3 changes: 1 addition & 2 deletions src/fe/fe_interface.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2676,8 +2676,7 @@ unsigned int FEInterface::max_order(const FEType & fe_t,
case HEX20:
return 0;
case HEX27:
return 2; // p=3+ is still buggy in 3D
// return unlimited;
return unlimited;
case PRISM6:
case PRISM15:
case PRISM18:
Expand Down
4 changes: 2 additions & 2 deletions tests/fe/fe_side_test.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,8 +582,8 @@ INSTANTIATE_FESIDETEST(FOURTH, SIDE_HIERARCHIC, TRI7);
INSTANTIATE_FESIDETEST(CONSTANT, SIDE_HIERARCHIC, HEX27);
INSTANTIATE_FESIDETEST(FIRST, SIDE_HIERARCHIC, HEX27);
INSTANTIATE_FESIDETEST(SECOND, SIDE_HIERARCHIC, HEX27);
//INSTANTIATE_FESIDETEST(THIRD, SIDE_HIERARCHIC, HEX27);
//INSTANTIATE_FESIDETEST(FOURTH, SIDE_HIERARCHIC, HEX27);
INSTANTIATE_FESIDETEST(THIRD, SIDE_HIERARCHIC, HEX27);
INSTANTIATE_FESIDETEST(FOURTH, SIDE_HIERARCHIC, HEX27);
//
INSTANTIATE_FESIDETEST(CONSTANT, SIDE_HIERARCHIC, TET14);
INSTANTIATE_FESIDETEST(FIRST, SIDE_HIERARCHIC, TET14);
Expand Down