Update TIMPI#3500
Merged
roystgnr merged 1 commit intolibMesh:develfrom Mar 25, 2023
Merged
Conversation
roystgnr
added a commit
to roystgnr/moose
that referenced
this pull request
Mar 23, 2023
The TIMPI docs always said we require action functors to take *const* lvalue references, but we seem to have never actually enforced that until we added the rvalue reference support. Refs libMesh/TIMPI#113 , where Alex describes making this change but I guess didn't actually push this change? This fixes libMesh/libmesh#3500 for me, and it'll be needed for the next libMesh submodule update too. Refs #000
Member
Author
|
I've got to remember that "fixes" is a Github keyword, not just a comment... |
Member
|
Following. I would really like to get this to moose next week if possible |
This gets us better error messages when timpi_parallel_only fails, Packing<tuple> fixes, better test coverage, better comments, more value support in the NBX algorithm, and the removal of `Packing` specifications for unpackable container types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gets us better error messages when timpi_parallel_only fails, Packing fixes, better test coverage, better comments, more rvalue support in the NBX algorithm, and the removal of
Packingspecifications for unpackable container types.Hopefully this goes better than the current Update-MetaPhysicL PR...