Make our use of isspace more robust#3508
Merged
roystgnr merged 2 commits intolibMesh:develfrom Apr 3, 2023
Merged
Conversation
We had some users of a modified libMesh who saw the existing code break here - their fault for bringing in a 3rd party header with `using namespace std` and thereby making `isspace` ambiguous, but the workaround is easy enough.
Member
|
Any chance you'd want to make the same update in |
jwpeterson
approved these changes
Mar 31, 2023
Member
Author
|
Huh; definitely. It wasn't a problem there because there's no std algorithm use and so no ambiguous template argument, but let me get them all (and getpot.h) while I'm at it. |
Member
Author
|
Wait, GMV is also using it in remove_if. I guess the polluting header just didn't end up in the dependencies there. |
|
Job Coverage on 5b40c68 wanted to post the following: Coverage
Warnings
This comment will be updated on new commits. |
||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had some users of a modified libMesh who saw the existing code break here - their fault for bringing in a 3rd party header with
using namespace std(thereby makingisspaceambiguous), but the workaround is easy enough, and I'm not a big fan of us including C headers when there's a C++ version around anyway.Pinging @rainiscold and @LabrosV ; hopefully I haven't typo'd either.