Add some missing RBParameters APIs for "extra" parameters#3576
Merged
jwpeterson merged 3 commits intolibMesh:develfrom Jun 6, 2023
Merged
Add some missing RBParameters APIs for "extra" parameters#3576jwpeterson merged 3 commits intolibMesh:develfrom
jwpeterson merged 3 commits intolibMesh:develfrom
Conversation
Initially I did not think I would need full multi-step support for getting the "extra" parameters, but it turns out we do, so I'm adding it now.
Again, we already had this support for "normal" parameters, so makes sense to add it for "extra" parameters as well.
|
Job Coverage on 8710a46 wanted to post the following: Coverage
Warnings
This comment will be updated on new commits. |
||||||||||||||||||||||||||
Member
Author
|
Same failure in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also add some unit tests so hopefully the coverage is not 0%.