Skip to content

Fix missing _n_steps initialization in RBParameters compatibility constructor #3586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwpeterson merged 2 commits into from
Jun 15, 2023
Merged

Fix missing _n_steps initialization in RBParameters compatibility constructor #3586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
981373f
Fix missing _n_steps initialization in RBParameters map-based constru…
jwpeterson Jun 14, 2023
c65252a
Add unit test checking that _n_steps is initialized by old constructor
jwpeterson Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/reduced_basis/rb_parameters.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ RBParameters::RBParameters() :
{
}

RBParameters::RBParameters(const std::map<std::string, Real> & parameter_map)
RBParameters::RBParameters(const std::map<std::string, Real> & parameter_map) :
_n_steps(1)
{
// Backwards compatible support for constructing an RBParameters
// object from a map<string, Real>. We store a single entry in each
Expand Down
4 changes: 4 additions & 0 deletions tests/utils/rb_parameters_test.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,10 @@ public:
CPPUNIT_ASSERT_EQUAL(params.get_value("a"), 1.);
CPPUNIT_ASSERT_EQUAL(params.get_value("b"), 2.);
CPPUNIT_ASSERT_EQUAL(params.get_value("c"), 3.);

// Test that RBParameters objects constructed with the old
// constructor have the correct number of steps.
CPPUNIT_ASSERT_EQUAL(params.n_steps(), 1u);
}

void testIterators()
Expand Down