Skip to content

Add in-place L2 norm difference method#3603

Merged
roystgnr merged 11 commits into
libMesh:develfrom
loganharbour:l2_norm_diff
Jul 25, 2023
Merged

Add in-place L2 norm difference method#3603
roystgnr merged 11 commits into
libMesh:develfrom
loganharbour:l2_norm_diff

Conversation

@loganharbour
Copy link
Copy Markdown
Member

No description provided.

@loganharbour
Copy link
Copy Markdown
Member Author

@roystgnr please

@loganharbour loganharbour force-pushed the l2_norm_diff branch 2 times, most recently from 773f9a1 to 44b7954 Compare July 10, 2023 22:07
@loganharbour loganharbour force-pushed the l2_norm_diff branch 3 times, most recently from 8feb745 to 2290192 Compare July 24, 2023 17:30
@loganharbour
Copy link
Copy Markdown
Member Author

loganharbour commented Jul 24, 2023

@jwpeterson - Roy is looking for your opinions for naming readable() and comparable() in f47a2a3; mind taking a look?

Edit: used the right commit

@jwpeterson
Copy link
Copy Markdown
Member

OK, so the question is just if those are good names for the functions? Seems OK to me, might change comparable -> compatible since the word "comparable" is commonly used in the context of STL strict weak orderings.

@loganharbour
Copy link
Copy Markdown
Member Author

OK, so the question is just if those are good names for the functions? S

Yep - that's it. We hit some stupid mistakes not understanding a result when we forgot to close, so decided to clean that up here.

might change comparable -> compatible since the word "comparable" is commonly used in the context of STL strict weak orderings.

Works for me.

@loganharbour
Copy link
Copy Markdown
Member Author

@roystgnr good to go.

@moosebuild
Copy link
Copy Markdown

Job Coverage on 5a0d7a2 wanted to post the following:

Coverage

c2728e #3603 5a0d7a
Total Total +/- New
Rate 61.88% 61.88% +0.01% 59.26%
Hits 66607 66625 +18 16
Misses 41039 41035 -4 11

Diff coverage report

Full coverage report

Warnings

  • New new line coverage rate 59.26% is less than the suggested 90.0%

This comment will be updated on new commits.

@roystgnr roystgnr merged commit c965dd6 into libMesh:devel Jul 25, 2023
@loganharbour loganharbour deleted the l2_norm_diff branch July 26, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants