Respect Abaqus node and element numbers a little#3640
Merged
roystgnr merged 1 commit intolibMesh:develfrom Sep 26, 2023
Merged
Conversation
lindsayad
approved these changes
Sep 11, 2023
Member
Author
Well at least this wasn't true. |
We're not going to respect them enough to not convert from 1-based to 0-based, of course[0], but we can at least stick to just that conversion and not give them whatever (sequential for nodes and replicated meshes, sequential with spacing for distributed meshes) ids we choose instead. [0] Dijkstra, E.W. "Why numbering should start at zero"
roystgnr
force-pushed
the
abaqus_numbering
branch
from
1a0b16d to
1bcd21e
Compare
Member
Author
|
I'd used |
|
Job Coverage on 1bcd21e wanted to post the following: Coverage
Warnings
This comment will be updated on new commits. |
||||||||||||||||||||||||||
Member
Author
|
Going to merge this, lest I forget to do so before the next submodule update. It's at least an improvement in the few tests we do have; if we hit regressions elsewhere we can fix them then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're not going to respect them enough to not convert from 1-based to 0-based, of course[0], but we can at least stick to just that conversion and not give them whatever (sequential for nodes and replicated meshes, sequential with spacing for distributed meshes) ids we choose instead.
[0] Dijkstra, E.W. "Why numbering should start at zero"
This is my crack at making life easier for @Traiwit in idaholab/moose#25440 ... who I'm really hoping can help test it, because it looks like we have zero test coverage of AbaqusIO right now?