Skip to content

Do more comprehensive setting of the hypre memory location #4035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lindsayad merged 1 commit into from
Dec 11, 2024
Merged

Do more comprehensive setting of the hypre memory location #4035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/solvers/petsc_linear_solver.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@
#include "libmesh/enum_solver_type.h"
#include "libmesh/enum_convergence_flags.h"

#ifdef LIBMESH_HAVE_PETSC_HYPRE
#include <HYPRE_utilities.h>
#endif

// C++ includes
#include <memory>
#include <string.h>
Expand Down Expand Up @@ -571,6 +575,19 @@ PetscLinearSolver<T>::solve_base (SparseMatrix<T> * matrix,
// Allow command line options to override anything set programmatically.
LibmeshPetscCall(KSPSetFromOptions(_ksp));

#if defined(LIBMESH_HAVE_PETSC_HYPRE) && !PETSC_VERSION_LESS_THAN(3,12,0) && defined(PETSC_HAVE_HYPRE_DEVICE)
{
// Make sure hypre has been initialized
LibmeshPetscCallExternal(HYPRE_Initialize);
PetscScalar * dummyarray;
PetscMemType mtype;
LibmeshPetscCall(VecGetArrayAndMemType(solution->vec(), &dummyarray, &mtype));
LibmeshPetscCall(VecRestoreArrayAndMemType(solution->vec(), &dummyarray));
if (PetscMemTypeHost(mtype))
LibmeshPetscCallExternal(HYPRE_SetMemoryLocation, HYPRE_MEMORY_HOST);
}
#endif

// If the SolverConfiguration object is provided, use it to override
// solver options.
if (this->_solver_configuration)
Expand Down
27 changes: 11 additions & 16 deletions src/solvers/petsc_nonlinear_solver.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1073,22 +1073,17 @@ PetscNonlinearSolver<T>::solve (SparseMatrix<T> & pre_in, // System Preconditi
#endif
LibmeshPetscCall(SNESSetFromOptions(_snes));

#if defined(LIBMESH_HAVE_PETSC_HYPRE) && !PETSC_VERSION_LESS_THAN(3,12,0)
// The above call set our PC type. If we're a hypre type we have to ensure that hypre is deployed
// in the same memory space as our vector types
PC pc;
LibmeshPetscCall(KSPGetPC(ksp, &pc));
PetscBool is_hypre;
LibmeshPetscCall(PetscObjectTypeCompare((PetscObject)pc, PCHYPRE, &is_hypre));
if (is_hypre == PETSC_TRUE)
{
PetscScalar * dummyarray;
PetscMemType mtype;
LibmeshPetscCall(VecGetArrayAndMemType(x->vec(), &dummyarray, &mtype));
LibmeshPetscCall(VecRestoreArrayAndMemType(x->vec(), &dummyarray));
if (PetscMemTypeHost(mtype))
LibmeshPetscCallExternal(HYPRE_SetMemoryLocation, HYPRE_MEMORY_HOST);
}
#if defined(LIBMESH_HAVE_PETSC_HYPRE) && !PETSC_VERSION_LESS_THAN(3,12,0) && defined(PETSC_HAVE_HYPRE_DEVICE)
{
// Make sure hypre has been initialized
LibmeshPetscCallExternal(HYPRE_Initialize);
PetscScalar * dummyarray;
PetscMemType mtype;
LibmeshPetscCall(VecGetArrayAndMemType(x->vec(), &dummyarray, &mtype));
LibmeshPetscCall(VecRestoreArrayAndMemType(x->vec(), &dummyarray));
if (PetscMemTypeHost(mtype))
LibmeshPetscCallExternal(HYPRE_SetMemoryLocation, HYPRE_MEMORY_HOST);
}
#endif

if (this->user_presolve)
Expand Down