Add backward compatibility for older RB-EIM data (read-only)#4043
Merged
jwpeterson merged 1 commit intolibMesh:develfrom Jan 6, 2025
Merged
Conversation
jwpeterson
approved these changes
Jan 6, 2025
Member
jwpeterson
left a comment
There was a problem hiding this comment.
@apicard95 Are you ready for this to be merged now or are you still doing some internal testing?
Author
|
@jwpeterson Almost all the tests are passing locally with local training. Only 1 or 2 have shown to be diffing compared to master but considering the current state of the pipelines, I don't think it is directly related to those changes. This PR should be more of a pass or break type of update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In summary, we convert old format training data to the new format during the reading stage.
Some older training data are qp based for several optional fields (JxW_all_qp, phi_i_all_qp, dxyzdxi, dxyzdeta...), the new version is elem based. To maintain backward compatibility when reading older training data, we check if n_elems is present in the set. If so and if the field is not empty, we lookup based on elems, otherwise we lookup based on qp but we make sure to remove potential duplicates and store that data based on elems.
The remaining optional field required is an elem_id_to_local_indexing map that is built during reading if optional fields are present and the training data is old format.