Skip to content

Add backward compatibility for older RB-EIM data (read-only)#4043

Merged
jwpeterson merged 1 commit intolibMesh:develfrom
apicard95:alexisp/rb_eim_data_backward_compatibility
Jan 6, 2025
Merged

Add backward compatibility for older RB-EIM data (read-only)#4043
jwpeterson merged 1 commit intolibMesh:develfrom
apicard95:alexisp/rb_eim_data_backward_compatibility

Conversation

@apicard95
Copy link
Copy Markdown

In summary, we convert old format training data to the new format during the reading stage.

Some older training data are qp based for several optional fields (JxW_all_qp, phi_i_all_qp, dxyzdxi, dxyzdeta...), the new version is elem based. To maintain backward compatibility when reading older training data, we check if n_elems is present in the set. If so and if the field is not empty, we lookup based on elems, otherwise we lookup based on qp but we make sure to remove potential duplicates and store that data based on elems.
The remaining optional field required is an elem_id_to_local_indexing map that is built during reading if optional fields are present and the training data is old format.

@moosebuild
Copy link
Copy Markdown

Job Coverage, step Generate coverage on 49debc0 wanted to post the following:

Coverage

c25a14 #4043 49debc
Total Total +/- New
Rate 62.32% 62.32% +0.00% -
Hits 72705 72706 +1 0
Misses 43954 43953 -1 0

Diff coverage report

Full coverage report

This comment will be updated on new commits.

Copy link
Copy Markdown
Member

@jwpeterson jwpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apicard95 Are you ready for this to be merged now or are you still doing some internal testing?

@apicard95
Copy link
Copy Markdown
Author

@jwpeterson Almost all the tests are passing locally with local training. Only 1 or 2 have shown to be diffing compared to master but considering the current state of the pipelines, I don't think it is directly related to those changes. This PR should be more of a pass or break type of update.

@jwpeterson jwpeterson merged commit c544498 into libMesh:devel Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants