Skip to content

Added option to normalize RB solution snapshots#4045

Merged
jwpeterson merged 4 commits intolibMesh:develfrom
dknez:eim_normalization_option
Jan 7, 2025
Merged

Added option to normalize RB solution snapshots#4045
jwpeterson merged 4 commits intolibMesh:develfrom
dknez:eim_normalization_option

Conversation

@dknez
Copy link
Copy Markdown
Member

@dknez dknez commented Jan 6, 2025

It can be useful to normalize solution snapshots in RB training, e.g. this is relevant if snapshots have different magnitudes and we want to treat them all on "equal footing."

Copy link
Copy Markdown
Member

@jwpeterson jwpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the second PR where I'm seeing failures during fetch and branch for ARM machines. @roystgnr @lindsayad any ideas?

Fatal Python error: init_fs_encoding: failed to get the Python codec of the filesystem encoding
Python runtime state: core initialized
ModuleNotFoundError: No module named 'encodings'

Comment thread src/reduced_basis/rb_construction.C Outdated
Comment thread src/reduced_basis/rb_eim_construction.C Outdated
@moosebuild
Copy link
Copy Markdown

Job Test ARM mac on 6ac7288 : invalidated by @lindsayad

@lindsayad
Copy link
Copy Markdown
Member

looks like someone invalidated it and now it's stuck. Let's try again

@jwpeterson
Copy link
Copy Markdown
Member

There is a complex mode build failure for this PR that looks legitimate:

../src/reduced_basis/rb_eim_construction.C: In member function 'void libMesh::RBEIMConstruction::apply_normalization_to_solution_snapshots()':
../src/reduced_basis/rb_eim_construction.C:652:24: error: no match for 'operator>' (operand types are 'libMesh::Number' {aka 'std::complex<double>'} and 'double')
  652 |           if (norm_val > 0.)
      |               ~~~~~~~~ ^ ~~
      |               |          |
      |               |          double
      |               libMesh::Number {aka std::complex<double>}
In file included from /opt/rh/gcc-toolset-12/root/usr/include/c++/12/string:47,
                 from /opt/rh/gcc-toolset-12/root/usr/include/c++/12/bits/locale_classes.h:40,
                 from /opt/rh/gcc-toolset-12/root/usr/include/c++/12/bits/ios_base.h:41,
                 from /opt/rh/gcc-toolset-12/root/usr/include/c++/12/ios:42,
                 from /opt/rh/gcc-toolset-12/root/usr/include/c++/12/istream:38,
                 from /opt/rh/gcc-toolset-12/root/usr/include/c++/12/fstream:38,
                 from ../src/reduced_basis/rb_eim_construction.C:21:

@dknez
Copy link
Copy Markdown
Member Author

dknez commented Jan 7, 2025

Thanks, I just pushed a fix.

@moosebuild
Copy link
Copy Markdown

moosebuild commented Jan 7, 2025

Job Coverage, step Generate coverage on 6dd327c wanted to post the following:

Coverage

c54449 #4045 6dd327
Total Total +/- New
Rate 62.34% 62.33% -0.01% 4.44%
Hits 72767 72770 +3 2
Misses 43952 43975 +23 43

Diff coverage report

Full coverage report

Warnings

  • New new line coverage rate 4.44% is less than the suggested 90.0%

This comment will be updated on new commits.

@jwpeterson jwpeterson merged commit cb6caaf into libMesh:devel Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants