netcdf: remove an autogenerated file.#4048
Merged
jwpeterson merged 1 commit intolibMesh:develfrom Jan 22, 2025
Merged
Conversation
This shouldn't be checked in and, due to the order of includes in NETCDF_INCLUDE, prevents the correct header from being read.
roystgnr
approved these changes
Jan 22, 2025
Member
|
Looks correct to me; if @jwpeterson doesn't chime in shortly please ping me again so I don't forget to merge. |
Member
|
It looks like this file has been there since 5fad618... Definitely agree that it should be removed, just not sure how it hasn't broken anything else before now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shouldn't be checked in and, due to the order of includes in
NETCDF_INCLUDE, prevents the correct header from being read.I found this while working on 1.7.6: it looks like the other half of this bug present on that branch (not adding
-I/$(top_srcdir)/contrib/netcdf/netcdf-c-4.6.2/include/toNETCDF_INCLUDE) was already fixed.