Skip to content

Skip misc_ex17 when PETSc is not enabled#4056

Merged
roystgnr merged 3 commits intolibMesh:develfrom
jwpeterson:fix_misc_ex17_disable_optional
Jan 22, 2025
Merged

Skip misc_ex17 when PETSc is not enabled#4056
roystgnr merged 3 commits intolibMesh:develfrom
jwpeterson:fix_misc_ex17_disable_optional

Conversation

@jwpeterson
Copy link
Copy Markdown
Member

FYI @lindsayad something like this is necessary to fix the libmesh devel -> master merge. I think the easiest thing is to skip the example when PETSc is not available.

Not strictly necessary, but I prefer this since it matches how all the
other examples are formatted.
@moosebuild
Copy link
Copy Markdown

Job Coverage, step Generate coverage on 45f092b wanted to post the following:

Coverage

591e06 #4056 45f092
Total Total +/- New
Rate 62.33% 62.33% -0.00% -
Hits 72790 72787 -3 0
Misses 43983 43986 +3 0

Diff coverage report

Full coverage report

This comment will be updated on new commits.

@roystgnr roystgnr merged commit 60d918d into libMesh:devel Jan 22, 2025
@jwpeterson jwpeterson deleted the fix_misc_ex17_disable_optional branch January 22, 2025 14:21
@lindsayad
Copy link
Copy Markdown
Member

man that's probably been failing for a while. Sorry guys. Feel free to DM me when stuff like this happens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants