Skip to content

Conversation

@lindsayad
Copy link
Member

Refs a failure that briefly cropped up on idaholab/moose#29700 and that I can get to trigger 100% of the time with a build with thread sanitizer

Refs a failure that briefly cropped up on idaholab/moose#29700
and that I can get to trigger 100% of the time with a build with
thread sanitizer
Copy link
Member

@jwpeterson jwpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will trust your expertise and testing on this one, don't know much about thread_local.

But, this PR also makes me think that there are probably a lot of places where we have carelessly used a static bool variable in the same way that need to be updated.

@moosebuild
Copy link

Job Coverage, step Generate coverage on 3bc6227 wanted to post the following:

Coverage

5d4c38 #4080 3bc622
Total Total +/- New
Rate 62.51% 62.51% +0.00% 0.00%
Hits 72990 72992 +2 0
Misses 43773 43772 -1 1

Diff coverage report

Full coverage report

Warnings

  • New new line coverage rate 0.00% is less than the suggested 90.0%

This comment will be updated on new commits.

@lindsayad lindsayad merged commit 05c9ac4 into libMesh:devel Feb 13, 2025
19 of 20 checks passed
@lindsayad lindsayad deleted the thread-safety-for-failed-point-inversion branch February 13, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants