Remove some no longer necessary changes for PETSc/hypre memory location#4120
Conversation
roystgnr
left a comment
There was a problem hiding this comment.
It's now handled upstream in PETSc; is there any reason to leave this in (in version guards) for older PETSc compatibility?
|
My older PETSc code that worked with this libMesh code that I'm now removing was still post 3.22 release, so this should be dead code for any PETSc release. Junchao Zhang just came along a couple months after me and wrote better code that made these downstream lines unnecessary 😄 |
|
I really think my brain is atrophying. I looked back at a PR from 2020 and thought to myself I was a lot smarter then. As I was falling asleep last night, I thought to myself ... "are you sure your code would be meaningless for all PETSc versions? Did you even check for PETSc version macros before responding to Roy?" And clearly I did not. It looks like this is not dead code between PETSc 3.12 and 3.23 😆 |
This is now handled upstream in PETSc