Skip to content

Remove some no longer necessary changes for PETSc/hypre memory location#4120

Merged
lindsayad merged 3 commits into
libMesh:develfrom
lindsayad:gpu-work
Mar 31, 2025
Merged

Remove some no longer necessary changes for PETSc/hypre memory location#4120
lindsayad merged 3 commits into
libMesh:develfrom
lindsayad:gpu-work

Conversation

@lindsayad
Copy link
Copy Markdown
Member

This is now handled upstream in PETSc

@moosebuild
Copy link
Copy Markdown

Job Coverage, step Generate coverage on 134e8b8 wanted to post the following:

Coverage

358b25 #4120 134e8b
Total Total +/- New
Rate 63.32% 63.32% +0.00% -
Hits 74331 74333 +2 0
Misses 43058 43056 -2 0

Diff coverage report

Full coverage report

This comment will be updated on new commits.

@lindsayad lindsayad marked this pull request as ready for review March 28, 2025 04:26
@lindsayad lindsayad requested a review from roystgnr March 28, 2025 04:26
Copy link
Copy Markdown
Member

@roystgnr roystgnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's now handled upstream in PETSc; is there any reason to leave this in (in version guards) for older PETSc compatibility?

@lindsayad
Copy link
Copy Markdown
Member Author

lindsayad commented Mar 31, 2025

My older PETSc code that worked with this libMesh code that I'm now removing was still post 3.22 release, so this should be dead code for any PETSc release. Junchao Zhang just came along a couple months after me and wrote better code that made these downstream lines unnecessary 😄

@lindsayad lindsayad merged commit 1fba560 into libMesh:devel Mar 31, 2025
@lindsayad lindsayad deleted the gpu-work branch March 31, 2025 23:17
@lindsayad
Copy link
Copy Markdown
Member Author

I really think my brain is atrophying. I looked back at a PR from 2020 and thought to myself I was a lot smarter then. As I was falling asleep last night, I thought to myself ... "are you sure your code would be meaningless for all PETSc versions? Did you even check for PETSc version macros before responding to Roy?" And clearly I did not. It looks like this is not dead code between PETSc 3.12 and 3.23 😆

lindsayad added a commit to lindsayad/libmesh that referenced this pull request Apr 1, 2025
This reverts commit 1fba560, reversing
changes made to e947c62.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants