Skip to content

Don't let GMSH physicals overwrite each other#4128

Merged
roystgnr merged 2 commits intolibMesh:develfrom
roystgnr:gmsh_physicals_fix
Apr 8, 2025
Merged

Don't let GMSH physicals overwrite each other#4128
roystgnr merged 2 commits intolibMesh:develfrom
roystgnr:gmsh_physicals_fix

Conversation

@roystgnr
Copy link
Copy Markdown
Member

@roystgnr roystgnr commented Apr 2, 2025

See #4125 for an example case.

@moosebuild
Copy link
Copy Markdown

moosebuild commented Apr 2, 2025

Job Coverage, step Generate coverage on 41aa571 wanted to post the following:

Coverage

bf64b0 #4128 41aa57
Total Total +/- New
Rate 63.39% 63.39% +0.01% 100.00%
Hits 74768 74776 +8 4
Misses 43189 43180 -9 0

Diff coverage report

Full coverage report

This comment will be updated on new commits.

@roystgnr
Copy link
Copy Markdown
Member Author

roystgnr commented Apr 3, 2025

No breakage other than the broken CI. I'll add a unit test and then this should be ready to merge.

@roystgnr roystgnr merged commit 083f7a0 into libMesh:devel Apr 8, 2025
19 of 20 checks passed
@roystgnr roystgnr deleted the gmsh_physicals_fix branch April 8, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants