Remove warnings guards around gzstream.h #4171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shadowing warnings we used to get were a gcc 8 bug, and should be fixed by now.
Member
Author
|
Huh. 8.5.0 on our min gcc tests, and it's definitely getting the --enable-paranoid-warnings --enable-werror testing, and it's passing. I think we're good to go here. |
jwpeterson
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shadowing warnings we used to get were a gcc 8 bug, and should be fixed by now.
I say "should be", of course, which does not imply "were". gcc 9.5 works fine for me, and hopefully 8.x is fine now too, but if our "Min gcc" CI recipes aren't happy then we'll just let this branch languish a while.