copy_nodes_and_elements metadata setting fixes #4175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We rely on that for skipping redundant preparation later, so we really don't want to turn that on if it might be incorrect and cause us to skip necessary preparation later.
We want to copy policies in our copy constructors, but *only* there, not in the method that specifically says it will not copy most "high level" data. This fixes a bug in the MOOSE reactor module for me. Unfortunately, this behavior is a 13 year old bug; hopefully other code hasn't come to depend on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to copy policies in our copy constructors, but only there, not in the method that specifically says it will not copy most "high level" data.
This fixes a bug in the MOOSE reactor module for me.
Unfortunately, this behavior is a 13 year old bug; hopefully other code hasn't come to depend on it.
While I was at it, I fixed a potential bug in the
set_isnt_prepared()logic; that turned out to be a red herring for this case but better safe than sorry for the future.