Skip to content

Fix for stitch_meshes() with NodeElem surface#4334

Merged
jwpeterson merged 6 commits intolibMesh:develfrom
jwpeterson:fix_stitch_meshes
Nov 21, 2025
Merged

Fix for stitch_meshes() with NodeElem surface#4334
jwpeterson merged 6 commits intolibMesh:develfrom
jwpeterson:fix_stitch_meshes

Conversation

@jwpeterson
Copy link
Copy Markdown
Member

When #4283 was merged, the NodeElem check got moved into a side loop, which didn't make any sense. This caused one of our internal tests to break, so I have now made that case into a small libmesh unit test so we can hopefully avoid this issue in the future.

This was broken when libMesh#4283 was merged.
To do the conversion, first ncdump the file to text:

    $LIBMESH_DIR/bin/ncdump foo.e > foo.txt

Edit the resulting text file so that it does not contain any features
not supported by older Exodus files. For example:

    :file_size = 1LL ;              --> :file_size = 1 ;
    int64 ns_prop1(num_node_sets) ; --> int ns_prop1(num_node_sets) ;

Then ncgen with the -k '64-bit offset' option:

    $LIBMESH_DIR/bin/ncgen foo.txt -k '64-bit offset' -o foo.e

The ncdump and ncgen commands are located in the bin/ directory of
your libmesh installation.
@moosebuild
Copy link
Copy Markdown

Job Coverage, step Generate coverage on 676777a wanted to post the following:

Coverage

fc27ed #4334 676777
Total Total +/- New
Rate 65.23% 65.25% +0.01% 100.00%
Hits 77358 77375 +17 8
Misses 41227 41211 -16 0

Diff coverage report

Full coverage report

This comment will be updated on new commits.

@jwpeterson jwpeterson merged commit fded133 into libMesh:devel Nov 21, 2025
22 checks passed
@jwpeterson jwpeterson deleted the fix_stitch_meshes branch November 21, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants