Skip to content

Add warning on using the absolute step tolerance with a PETSc nonlinear solver #4339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roystgnr merged 2 commits into from
Nov 24, 2025
Merged

Add warning on using the absolute step tolerance with a PETSc nonlinear solver #4339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0416111
Add warning on using the absolute step tolerance
GiudGiud Nov 23, 2025
e7da3a2
Add warning for relative step tolerance, unused by trilinos solver
GiudGiud Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/solvers/petsc_nonlinear_solver.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -970,6 +970,10 @@ PetscNonlinearSolver<T>::solve (SparseMatrix<T> & pre_in, // System Preconditi
this->max_nonlinear_iterations,
this->max_function_evaluations));

// Not supported by PETSc
if (this->absolute_step_tolerance != 0) // 0 is default value, both in MOOSE and libMesh
libmesh_warning("Setting the absolute step tolerance is not supported with the PETSc nonlinear solver.");

// Set the divergence tolerance for the non-linear solver
#if !PETSC_VERSION_LESS_THAN(3,8,0)
LibmeshPetscCall(SNESSetDivergenceTolerance(_snes, this->divergence_tolerance));
Expand Down
3 changes: 3 additions & 0 deletions src/solvers/trilinos_nox_nonlinear_solver.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,9 @@ NoxNonlinearSolver<T>::solve (SparseMatrix<T> & /* jac_in */, // System Jacobi
Teuchos::RCP<NOX::Epetra::Group> grpPtr = Teuchos::rcp(new NOX::Epetra::Group(printParams, iReq, x, linSys));
NOX::Epetra::Group & grp = *(grpPtr.get());

if (this->relative_step_tolerance != 0) // 0 is default value
libmesh_warning("Setting the relative step tolerance is currently not supported with the trilinos nox nonlinear solver.");

Teuchos::RCP<NOX::StatusTest::NormF> absresid =
Teuchos::rcp(new NOX::StatusTest::NormF(this->absolute_residual_tolerance, NOX::StatusTest::NormF::Unscaled));
Teuchos::RCP<NOX::StatusTest::NormF> relresid =
Expand Down