restrict_int<T>() for opt-checked casts, starting with subdomain_id inputs#4439
Open
roystgnr wants to merge 3 commits intolibMesh:develfrom
Open
restrict_int<T>() for opt-checked casts, starting with subdomain_id inputs#4439roystgnr wants to merge 3 commits intolibMesh:develfrom
roystgnr wants to merge 3 commits intolibMesh:develfrom
Conversation
We need this for things like file input where we really can't just assume that the file contents are compatible with our data types.
|
Job Test MOOSE modules on 23b0101 : invalidated by @roystgnr Kicking in the hopes that the chemical_reactions/test:thermochimica.MoRu_FV failure was an MPI fluke... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm certain that we need something that does conversion checking even in opt mode - otherwise we can get silent corruption and/or confusing failures when we try to read a subdomain_id above ~2^16 with a libMesh build that's using our default 16-bit
subdomain_id_type. That seemed to be happening to me with the file @jwpeterson sent me to look at regarding #4358.I'm not certain about the name here. In hindsight, perhaps even
cast_intshould have been calledcast_value, since these methods would be useful for FP/integer interconversions (and maybe for FP/FP conversions) too?