Skip to content

Have qhull do PIC in libs #4463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roystgnr merged 2 commits into from
May 20, 2026
+8 −2
Merged

Have qhull do PIC in libs #4463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c3baa9
Make sure qhull libs have PIC
lindsayad May 19, 2026
e4a01bd
Run bootstrap
lindsayad May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion configure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59326,8 +59326,9 @@ then :

mkdir -p contrib/qhull/install

if (cd contrib/qhull/build && \
if (cd contrib/qhull/build && \
cmake -DBUILD_SHARED_LIBS=OFF \
-DCMAKE_POSITION_INDEPENDENT_CODE=ON \
-DQHULL_ENABLE_TESTING=OFF \
-DBUILD_APPLICATIONS=OFF \
-DCMAKE_INSTALL_PREFIX:PATH=$my_top_builddir/contrib/qhull/install \
Expand Down
7 changes: 6 additions & 1 deletion m4/qhull.m4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,14 @@ AC_DEFUN([CONFIGURE_QHULL],

dnl Build static libraries only to avoid RPATH issues in
dnl the build tree. Disable tests and applications to
dnl keep the build lean.
dnl keep the build lean. Force -fPIC on the static
dnl archives so they can be linked into libmesh's shared
dnl library; qhull's CMakeLists only sets
dnl POSITION_INDEPENDENT_CODE on libqhullcpp, not on
dnl libqhullstatic_r.
AS_IF([(cd contrib/qhull/build && \
cmake -DBUILD_SHARED_LIBS=OFF \
-DCMAKE_POSITION_INDEPENDENT_CODE=ON \
-DQHULL_ENABLE_TESTING=OFF \
-DBUILD_APPLICATIONS=OFF \
-DCMAKE_INSTALL_PREFIX:PATH=$my_top_builddir/contrib/qhull/install \
Expand Down