Gdb command fix#4472
Open
roystgnr wants to merge 3 commits into
Open
Conversation
This way we can use the preprocessor to check when it's undefined, not just the compiler.
Don't futz with comparing GDB_COMMAND to "no" at run-time (this fixes an "unreachable code" warning for me with GDB_COMMAND=no with my clang++ and newer C++ standards) Do allow for run-time `--gdb=` even if it was disabled at compile-time.
Member
Author
|
This isn't urgent, and I don't want to merge it until I've done more manual testing than "notice that it got rid of my compiler's unreachable code warning", but it's rebased and ready to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll rebase this after #4471 gets the first few commits in; the remaining diff will be much cleaner. I just want to get this posted before I forget about it, and in CI to make sure I haven't screwed it up.