Fix petsc version check in update_preallocation_and_zero() #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This appears to be the case with the current default PETSc build on Ubuntu 14.10
The relevant patch, https://bitbucket.org/petsc/petsc/diff/include/petsc-private/matimpl.h?diff2=e56f5c9e9faa&at=karlrupp/feature-gpu-handle-access-for-vec predates the last of the 3.4.x series, but doesn't seem to have made it into an official release until 3.5. This fixes compilation with PETSc 3.4.2 for me.
Member
Author
|
Huh. That was a lot of wasted minutes on bitbucket in lieu of spending 5 seconds remembering to "git pull". |
|
Results of testing 3ec45ab using libmesh_PR_test recipe: Passed on: linux-gnu View the results here: https://www.moosebuild.com/view_job/13919 |
|
Results of testing 3ec45ab using libmesh_PR_test_dbg recipe: Passed on: linux-gnu View the results here: https://www.moosebuild.com/view_job/13920 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes compilation errors for me with PETSc 3.4.2.
It's built on top of the Ubuntu-PETSc configure error fixes in #518