Bugfix for create_submesh() with ParallelMesh #562
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to Harshad Sahasrabudhe for catching this!
Member
Author
|
Let's hold off on merging for now; there are other bugs with this configuration so they might as well be added to this PR. |
|
Results of testing 11ef452 using libmesh_PR_test recipe: Passed on: linux-gnu View the results here: https://www.moosebuild.com/view_job/15896 |
|
Results of testing 11ef452 using libmesh_PR_test_dbg recipe: Passed on: linux-gnu View the results here: https://www.moosebuild.com/view_job/15897 |
Member
Author
|
Canceling this for now. It's not the right fix in general, and until a few related bugs are fixed it won't be a working fix even in the particular "input mesh is serialized" case. |
Member
Author
|
This got fixed for real in #566 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to Harshad Sahasrabudhe for catching this!